fix pad_to_max_length -> padding in transformers tokenizer encode
#601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-indrbane
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
…code Reproduction steps: transformers == 4.55.0 download alpaca dataset run command python -m QEfficient.cloud.finetune --device qaic --model_name \ meta-llama/Llama-3.1-8B --tokenizer_name meta-llama/Llama-3.1-8B \ --max_train_step 20 --output_dir \ meta-llama/Llama-3.1-8B_alpaca_dataset_run --dataset alpaca_dataset \ --run_validation False Expected error: TypeError: PreTrainedTokenizerFast._batch_encode_plus() got an unexpected keyword argument 'pad_to_max_length' Signed-off-by: Indrajit Banerjee <indrbane@qti.qualcomm.com>
quic-indrbane
force-pushed
the
indrbane/padding_fix
branch
from
f469be4 to
cd0b80e
Compare
Contributor
quic-akuruvil
left a comment
quic-akuruvil
left a comment
There was a problem hiding this comment.
Hi @quic-indrbane 599 PR is already doing the same fix. Will merge that on priority to unblock the FT activities.
Contributor
|
can we close this PR as changes is added as part of #599 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…code
Reproduction steps:
transformers == 4.55.0
download alpaca dataset
run command
python -m QEfficient.cloud.finetune --device qaic --model_name
meta-llama/Llama-3.1-8B --tokenizer_name meta-llama/Llama-3.1-8B
--max_train_step 20 --output_dir
meta-llama/Llama-3.1-8B_alpaca_dataset_run --dataset alpaca_dataset
--run_validation False
Expected error:
TypeError: PreTrainedTokenizerFast._batch_encode_plus() got an unexpected keyword argument 'pad_to_max_length'